Some enhancements for Dottydoc and ScalaDays #2477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
force-pushed
the
topic/dottydoc-scaladays-enhancements
branch
from
45675d8 to
2577ccd
Compare
DarkDimius
reviewed
May 19, 2017
| path: List[String], | ||
| superTypes: List[MaterializableLink] = Nil, | ||
| var comment: Option[Comment] = None, | ||
| var companionPath: List[String] = Nil, | ||
| var parent: Entity = NonEntity | ||
| ) extends Object | ||
| ) extends Object { | ||
| def modifiers: List[String] = mods.filterNot(_ == "private") |
There was a problem hiding this comment.
waps, it should indeed!
felixmulder
force-pushed
the
topic/dottydoc-scaladays-enhancements
branch
from
2577ccd to
e80f4fb
Compare
| "-project-version", | ||
| "project version", | ||
| "The current version of your project", | ||
| "" |
There was a problem hiding this comment.
If the version isn't specified, it falls back to an empty string. This renders nicely on the site.
nicolasstucki
approved these changes
May 19, 2017
|
The new side bar looks nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.